-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46358/#review129581
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 304)
<https://reviews.apache.org/r/46358/#comment193009>

    Prefix the function with "_" since scope of this function is very limited 
to LLAP.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 310)
<https://reviews.apache.org/r/46358/#comment193007>

    Should check that output is not None first.
    Perhaps include in the code comments what the sample output looks like.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 330)
<https://reviews.apache.org/r/46358/#comment193034>

    Typo in pecent_desired_instances_to_be_up



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 336)
<https://reviews.apache.org/r/46358/#comment193010>

    Remove semicolon



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 338)
<https://reviews.apache.org/r/46358/#comment193011>

    Check that llap_app_info is not None



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 339)
<https://reviews.apache.org/r/46358/#comment193012>

    convert to uppercase



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 346)
<https://reviews.apache.org/r/46358/#comment193013>

    Use pythonic_function_names



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 387)
<https://reviews.apache.org/r/46358/#comment193035>

    Since this is a while True loop, I prefer to use >=  here, and 
    "if app_running_partial_wait_ctr < num_times_to_iterate" above


- Alejandro Fernandez


On April 19, 2016, 1:42 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46358/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 1:42 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15959
>     https://issues.apache.org/jira/browse/AMBARI-15959
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Incorporate 'llap status check' to be used for (1). Before Hive Server 
> Interactive start, and (2). status call.
> 
> - Currently, code calls are commented as "hive --service llapstatus --name 
> llap0" command is always showing app status as LAUNCHING. Following up with 
> HIVE team.
> - Further, changed hive.llap.daemon.service.hosts value to @llap0.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  0b3de15 
>   ambari-server/src/test/python/stacks/2.5/HIVE/appComplete.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/invalidApp.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/oneContainerDown.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/running.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/starting.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> ac4f6fc 
> 
> Diff: https://reviews.apache.org/r/46358/diff/
> 
> 
> Testing
> -------
> 
> - UT added for this functionality tested.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to