-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46358/#review129661
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 337)
<https://reviews.apache.org/r/46358/#comment193158>

    convert to upper() as well



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 (line 499)
<https://reviews.apache.org/r/46358/#comment193159>

    we can also give a default value here, such as 10


- Alejandro Fernandez


On April 20, 2016, 12:56 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46358/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 12:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15959
>     https://issues.apache.org/jira/browse/AMBARI-15959
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Incorporate 'llap status check' to be used for (1). Before Hive Server 
> Interactive start, and (2). status call.
> 
> - Further, changed hive.llap.daemon.service.hosts value to @llap.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9bee786 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  88541bd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  0b3de15 
>   ambari-server/src/test/python/stacks/2.5/HIVE/appComplete.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/invalidApp.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/oneContainerDown.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/oneContainerDown1.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/running.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/starting.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> ac4f6fc 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json f9c31dc 
> 
> Diff: https://reviews.apache.org/r/46358/diff/
> 
> 
> Testing
> -------
> 
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to