-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46358/#review129687
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 149)
<https://reviews.apache.org/r/46358/#comment193194>

    it says llap here but the const below, LLAP_APP_NAME is llap0



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 349)
<https://reviews.apache.org/r/46358/#comment193197>

    Log the json output as well - will be easier to debug later.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 352)
<https://reviews.apache.org/r/46358/#comment193198>

    This may be risky - all initialization of desired_instances is inside some 
if. If code gets refactored then its possible to miss initialization of the 
variable in some path. Initialize these at the same scope as all usage and then 
over-write values in if conditions as needed.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 358)
<https://reviews.apache.org/r/46358/#comment193199>

    Can desired_instances be 0 at this point?



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 376)
<https://reviews.apache.org/r/46358/#comment193196>

    Create a single string and use that to Log as well as Fail



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 386)
<https://reviews.apache.org/r/46358/#comment193195>

    Change it to something like - App {} did not come up after a wait of {} 
seconds.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 (line 512)
<https://reviews.apache.org/r/46358/#comment193200>

    Is this property - num_retries_for_checking_llap_status optional? If not 
then lets just read it rather than using the "default" function



ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 (line 360)
<https://reviews.apache.org/r/46358/#comment193201>

    Is it @llap0 or llap0 - without the @


- Sumit Mohanty


On April 20, 2016, 5:25 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46358/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 5:25 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15959
>     https://issues.apache.org/jira/browse/AMBARI-15959
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Incorporate 'llap status check' to be used for (1). Before Hive Server 
> Interactive start, and (2). status call.
> 
> - Further, changed hive.llap.daemon.service.hosts value to @llap.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  0a2105d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  ca227b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  88541bd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  0b3de15 
>   ambari-server/src/test/python/stacks/2.5/HIVE/appComplete.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/invalidApp.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/oneContainerDown.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/oneContainerDown1.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/running.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/starting.json PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 845459a 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json d077c35 
> 
> Diff: https://reviews.apache.org/r/46358/diff/
> 
> 
> Testing
> -------
> 
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to