----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review129878 -----------------------------------------------------------
ambari-web/app/mixins/wizard/assign_master_components.js (line 965) <https://reviews.apache.org/r/46405/#comment193427> If you change logic of function or method do not forget to update comment that is related to your changes. ambari-web/app/mixins/wizard/assign_master_components.js (line 978) <https://reviews.apache.org/r/46405/#comment193428> This check can be simplified, after you added: "(this.get('hosts').filterProperty('host_name', selectedHost).filterProperty('maintenance_state', 'OFF').length > 0)" there is no need in : "this.get('hosts').mapProperty('host_name').contains(selectedHost)" This is because : "this.get('hosts').filterProperty('host_name', selectedHost)" will do the same thing as this.get('hosts').mapProperty('host_name').contains(selectedHost) - Alexandr Antonenko On April 19, 2016, 8:36 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46405/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 8:36 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg > Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15519 > https://issues.apache.org/jira/browse/AMBARI-15519 > > > Repository: ambari > > > Description > ------- > > On the cluster where some nodes are in the maintenance mode Add Service > Wizard doesn't track this. > So, user may select host in the maintenance mode to install some master > component. And this component won't be installed (only record in the DB will > be created for it). > Another situation: > there is some cluster where all nodes are in the maintenance mode. In this > case ASW is almost useless. Because all new components won't be installed > while it works. > > ASW should track hosts in the maintenance mode and warn user about adding > components on them (Steps "Assign Masters", "Assign Slaves and Clients"). > > > Diffs > ----- > > ambari-web/app/controllers/wizard.js adce5ff > ambari-web/app/mixins/wizard/assign_master_components.js cd8ef14 > ambari-web/app/utils/ajax/ajax.js a1d3f5f > ambari-web/test/controllers/main/service/add_controller_test.js 90670a8 > ambari-web/test/controllers/wizard/step5_test.js 935d76d > > Diff: https://reviews.apache.org/r/46405/diff/ > > > Testing > ------- > > Modified unit test. > Local ambari-web test passed. > 25680 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
