> On April 22, 2016, 4 p.m., Andrii Tkach wrote: > > ambari-web/app/controllers/wizard.js, line 749 > > <https://reviews.apache.org/r/46405/diff/2/?file=1355220#file1355220line749> > > > > I don't think that's good approach to set maintenance_state to not > > installed hosts, it may cause confusion in the future.
1. Well, maintenance_state is OFF means that the host is not in maintainance, which is technically true in installation scenario. 2. We could, of course, ask BE to send the maintainance_state, while they are sending other properties (i.e. cpu, memory, os_type). 3. However, since we know that BE will always send maintenance_state: "OFF" during the installation, I think we could set it directly without create another BE JIRA to ask them to provide it. 4. After all, this tempprary model will be discarded after the installation. And it's quite safe to say, the host will remain the maintenance_state to be OFF during the installation. - Zhe (Joe) ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130109 ----------------------------------------------------------- On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46405/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 6:50 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, > Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15519 > https://issues.apache.org/jira/browse/AMBARI-15519 > > > Repository: ambari > > > Description > ------- > > On the cluster where some nodes are in the maintenance mode Add Service > Wizard doesn't track this. > So, user may select host in the maintenance mode to install some master > component. And this component won't be installed (only record in the DB will > be created for it). > Another situation: > there is some cluster where all nodes are in the maintenance mode. In this > case ASW is almost useless. Because all new components won't be installed > while it works. > > ASW should track hosts in the maintenance mode and warn user about adding > components on them (Steps "Assign Masters", "Assign Slaves and Clients"). > > > Diffs > ----- > > ambari-web/app/controllers/wizard.js 52fb241 > ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 > > Diff: https://reviews.apache.org/r/46405/diff/ > > > Testing > ------- > > Modified unit test. > Local ambari-web test passed. > 25680 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
