-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130111
-----------------------------------------------------------




ambari-web/app/mixins/wizard/assign_master_components.js (line 979)
<https://reviews.apache.org/r/46405/#comment193777>

    We can check that maintenance_state is OFF, only when host has this 
property.


- Andrii Tkach


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
>     https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> -------
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Reply via email to