-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/
-----------------------------------------------------------
(Updated May 19, 2016, 11:58 a.m.)
Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.
Bugs: AMBARI-16752
https://issues.apache.org/jira/browse/AMBARI-16752
Repository: ambari
Description
-------
In service install wizard, pxf-hbase.jar should be added to the HBASE_CLASSPATH
(recommendation and validation)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py
e2510eb
ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py
PRE-CREATION
Diff: https://reviews.apache.org/r/47580/diff/
Testing
-------
Manually Tested.
Unit tests added.
```
test_createComponentLayoutRecommendations_hawq_1_Host
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_createComponentLayoutRecommendations_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when
HAWQ has already been installed ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard,
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_hawqsegment_cluster_install
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard,
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_no_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF does not get recommended during Add Service Wizard, when PXF has
already been installed ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Add Service Wizard, when PXF is
selected for installation ... ok
test_createComponentLayoutRecommendations_pxf_cluster_install
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Cluster Install Wizard, when
PXF is selected for installation ... ok
test_getComponentLayoutValidations_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test layout validations for HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode
(test_stack_advisor.TestHDP23StackAdvisor)
Test validation warning for HAWQ segment not colocated with DATANODE ... ok
test_getComponentLayoutValidations_nohawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE ... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE
... ok
test_getComponentLayoutValidations_sparkts_no_hive
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is not installed ... ok
test_getComponentLayoutValidations_sparkts_with_hive
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is installed ... ok
test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendFalconConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendHAWQConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHBASEConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHiveConfigurations_with_atlas
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendKAFKAConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendLogsearchConfiguration (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendRangerConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendRangerKMSConfigurations
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendSqoopConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendStormConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendTezConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendYARNConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_validateHAWQHdfsClientConfigurations
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_validateHAWQSiteConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_validateHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_validateHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
----------------------------------------------------------------------
Ran 37 tests in 1.480s
OK
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
test_execute (test_alerts_api_status.TestAlertsApiStatus) ... No handlers could
be found for logger "ambari_alerts"
ok
test_get_pxf_protocol_version (test_alerts_api_status.TestAlertsApiStatus) ...
ok
test_configure_default (test_pxf.TestPxf) ... ok
test_install_default (test_pxf.TestPxf) ... ok
test_start_default (test_pxf.TestPxf) ... ok
test_status_default (test_pxf.TestPxf) ... ok
test_stop_default (test_pxf.TestPxf) ... ok
test_getConfigurationsValidationItems
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
----------------------------------------------------------------------
Ran 9 tests in 0.033s
OK
SiteName: hbase-env, method: validatePXFHBaseEnvConfigurations
Site properties: {'content': '# Some hbase-env content text'}
Recommendations: {'content': '# Some hbase-env content text'}
********
```
Thanks,
Matt
