----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review134370 -----------------------------------------------------------
ambari-metrics/ambari-metrics-common/pom.xml (line 78) <https://reviews.apache.org/r/47730/#comment199155> This will collide due to Hadoop dependency in version 14.0.1, I faced a problem here before. Can we make this shaded ? - Sid Wagle On May 23, 2016, 3:48 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47730/ > ----------------------------------------------------------- > > (Updated May 23, 2016, 3:48 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid > Wagle. > > > Bugs: AMBARI-16821 > https://issues.apache.org/jira/browse/AMBARI-16821 > > > Repository: ambari > > > Description > ------- > > The TimelineMetricsCache implementation in the metrics sink side is currently > a ConcurrentSkipListMap. It is better to use pre built cache libraries like > Guava that offer more support. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-common/pom.xml 5a388dd > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java > 0bed7d0 > > ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java > 18d973c > > Diff: https://reviews.apache.org/r/47730/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
