----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/ -----------------------------------------------------------
(Updated Май 31, 2016, 7:03 д.п.) Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid Wagle. Bugs: AMBARI-16821 https://issues.apache.org/jira/browse/AMBARI-16821 Repository: ambari Description ------- The TimelineMetricsCache implementation in the metrics sink side is currently a ConcurrentSkipListMap. It is better to use pre built cache libraries like Guava that offer more support. Diffs (updated) ----- ambari-metrics/ambari-metrics-common/pom.xml 41ba62e ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java 0bed7d0 ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java 18d973c ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 3d4a929 ambari-server/pom.xml 20d3fab Diff: https://reviews.apache.org/r/47730/diff/ Testing ------- Unit tests passed Thanks, Dmytro Sen