-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136439
-----------------------------------------------------------




ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 (line 128)
<https://reviews.apache.org/r/48044/#comment201491>

    Instead of using {sudo} param. Can we use something like this:
    
    Execute(('ls','-la','/usr/hdp', sudo=True)
    
    This will ensure that we add specific flags for older sudo packages.


- Andrew Onischuk


On June 7, 2016, 8:17 a.m., Laszlo Puskas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 8:17 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
>     https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> The patch only applies for 2.2-next versions.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed.
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Reply via email to