----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50302/#review143210 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On July 22, 2016, 12:11 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50302/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 12:11 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate > Cole, and Sumit Mohanty. > > > Bugs: AMBARI-17836 > https://issues.apache.org/jira/browse/AMBARI-17836 > > > Repository: ambari > > > Description > ------- > > During Mission Control testing, it was clear that we were making 1000's of > database calls during the creation of the orchestration for upgrades. These > mostly revolved around getting configuration tags which was silly since we > were always refreshing them before executing the command. > > I decided that if you're specifying that the config tags shoudl be refreshed, > then there's no need to do any of the work ahead of time to fetch them. This > significantly reduced the number of hot methods during the orchestration of > an upgrade. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 1e7b1b6 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > 205ef9f > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java > ef12c3a > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 28de8ed > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 399f26c > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > 9c2db1c > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 2174a64 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 066acab > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > af24a69 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > c390f44 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 216d850 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 8dcd163 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 7a5f377 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > 37a2e63 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java > 9603226 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java > 115b518 > > Diff: https://reviews.apache.org/r/50302/diff/ > > > Testing > ------- > > Existing test failures in trunk not related to my changes. > > Results : > > Failed tests: > > ConfigUpgradeValidityTest.testConfigurationDefinitionsExist:152->assertIdDefinitionExists:189 > Missing hdp_2_3_0_0_kafka_broker_deprecate_port in upgrade from HDP-2.2 to > HDP-2.3 (ROLLING) > Tests in error: > ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:48 ยป Ambari File > /Us... > > Tests run: 4546, Failures: 1, Errors: 1, Skipped: 34 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 41:10 min > [INFO] Finished at: 2016-07-21T16:42:51-04:00 > [INFO] Final Memory: 36M/637M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
