----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52266/#review150708 -----------------------------------------------------------
ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java (line 147) <https://reviews.apache.org/r/52266/#comment218759> Two unnecessary blank lines. - Attila Doroszlai On Sept. 28, 2016, 11:57 a.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52266/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 11:57 a.m.) > > > Review request for Ambari, Attila Doroszlai, Jayush Luniya, Oliver Szabo, and > Sebastian Toader. > > > Bugs: AMBARI-18467 > https://issues.apache.org/jira/browse/AMBARI-18467 > > > Repository: ambari > > > Description > ------- > > Problems during cluster install can result in clusters without a cluster > version. UpdateActiveRepoVersionOnStartup.process() threw NPE in these case. > NPE check is added > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java > 1413c66 > > ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java > 9c54a88 > > Diff: https://reviews.apache.org/r/52266/diff/ > > > Testing > ------- > > - Added a new unit test > - All unit tests in ambari-server passed > - Did manual testing to verify (removed cluster version from the DB and > restarted the server) > > > Thanks, > > Balázs Bence Sári > >
