> On Oct. 20, 2016, 4:52 p.m., Sid Wagle wrote: > > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py, line 56 > > <https://reviews.apache.org/r/52420/diff/5/?file=1542350#file1542350line56> > > > > This looks weird I would think you would need a > > self.statusCommandsExecutor reference to point to this new executor, would > > this not get lost after 1st re-spawn?
Dropped my previous comment since it is not exactly valid but there is no reference to the newly respawned executor right? I think the controller should always have a handle on the executor. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153416 ----------------------------------------------------------- On Oct. 20, 2016, 3:54 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52420/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 3:54 p.m.) > > > Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18505 > https://issues.apache.org/jira/browse/AMBARI-18505 > > > Repository: ambari > > > Description > ------- > > SmartSense status command does an http call without timeout in 1.2 version of > SS. > > Ambari agent queues STATUS commands until we end up with HB lost state with > ton of commands queued up. > > This should just never happen is commands are getting queued by by the agent > every HB. > > > Diffs > ----- > > ambari-agent/conf/unix/ambari-agent.ini 914e09a > ambari-agent/src/main/python/ambari_agent/Controller.py 2a4d384 > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/52420/diff/ > > > Testing > ------- > > unit tests are pending to be added. Patch is not final > > > Thanks, > > Andrew Onischuk > >
