----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153451 -----------------------------------------------------------
Fix it, then Ship it! Pending unit tests for the patch, +1 for the impl. ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py (line 57) <https://reviews.apache.org/r/52420/#comment222770> Reference to the executor should not be lost. - Sid Wagle On Oct. 20, 2016, 3:54 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52420/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 3:54 p.m.) > > > Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18505 > https://issues.apache.org/jira/browse/AMBARI-18505 > > > Repository: ambari > > > Description > ------- > > SmartSense status command does an http call without timeout in 1.2 version of > SS. > > Ambari agent queues STATUS commands until we end up with HB lost state with > ton of commands queued up. > > This should just never happen is commands are getting queued by by the agent > every HB. > > > Diffs > ----- > > ambari-agent/conf/unix/ambari-agent.ini 914e09a > ambari-agent/src/main/python/ambari_agent/Controller.py 2a4d384 > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/52420/diff/ > > > Testing > ------- > > unit tests are pending to be added. Patch is not final > > > Thanks, > > Andrew Onischuk > >
