> On Oct. 20, 2016, 6:11 p.m., Andrew Onischuk wrote: > > The blacklisting logic we previously were implementing is not needed now > > (as disscussed with Sid). > > > > Reasons for that: > > 1. If command takes more than 5 seconds, the executor will just restart > > itself and continue to execute other status commands. > > 2. Also since status commands run parallel to the agent as of now, we won't > > get into situations where some timeouted commands, can make heartbeat hang, > > the results will just come back with the next heartbeat.
3. Status commands queue cannot get full due to timeouted commands. Because with every new pack of status commands, old commands get removed from queue. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52420/#review153434 ----------------------------------------------------------- On Oct. 20, 2016, 3:54 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52420/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 3:54 p.m.) > > > Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18505 > https://issues.apache.org/jira/browse/AMBARI-18505 > > > Repository: ambari > > > Description > ------- > > SmartSense status command does an http call without timeout in 1.2 version of > SS. > > Ambari agent queues STATUS commands until we end up with HB lost state with > ton of commands queued up. > > This should just never happen is commands are getting queued by by the agent > every HB. > > > Diffs > ----- > > ambari-agent/conf/unix/ambari-agent.ini 914e09a > ambari-agent/src/main/python/ambari_agent/Controller.py 2a4d384 > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/52420/diff/ > > > Testing > ------- > > unit tests are pending to be added. Patch is not final > > > Thanks, > > Andrew Onischuk > >
