> On Oct. 31, 2016, 3:10 p.m., Di Li wrote: > > ambari-server/src/main/python/ambari_server/utils.py, line 150 > > <https://reviews.apache.org/r/53273/diff/1/?file=1548411#file1548411line150> > > > > Use constants and corresponding defaults instead of text > > client.api.port, api.ssl, client.api.ssl.port. > > > > i.e > > from ambari_server.serverConfiguration import CLIENT_API_PORT, > > CLIENT_API_PORT_PROPERTY, SSL_API, DEFAULT_SSL_API_PORT, SSL_API_PORT
Updated the patch based on your comments and Attila's, I created a function in serverConfiguration and imported it in utils.py. I have imported it within the function wait_for_pid due to circular dependency. - Anita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154267 ----------------------------------------------------------- On Oct. 28, 2016, 9:46 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53273/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2016, 9:46 p.m.) > > > Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18741 > https://issues.apache.org/jira/browse/AMBARI-18741 > > > Repository: ambari > > > Description > ------- > > After including client.api.port in ambari.properties, ambari-server still > tries to connect to port 8080 > > The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is > defined in ambari.properties then the value should be taken as the port > number. > > https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/utils.py 5886561 > > Diff: https://reviews.apache.org/r/53273/diff/ > > > Testing > ------- > > Performed manual testing. > > > Thanks, > > Anita Jebaraj > >
