> On Nov. 2, 2016, 9:18 a.m., Attila Doroszlai wrote: > > ambari-server/src/test/python/TestUtils.py, line 130 > > <https://reviews.apache.org/r/53273/diff/3/?file=1550521#file1550521line130> > > > > I think get_properties_mock was added to avoid this error: > > > > ``` > > Failed tests: > > ERROR: test_wait_for_pid (TestUtils.TestUtils) > > ---------------------------------------------------------------------- > > Traceback (most recent call last): > > File "ambari-common/src/test/python/mock/mock.py", line 1199, in > > patched > > return func(*args, **keywargs) > > File "ambari-server/src/test/python/TestUtils.py", line 129, in > > test_wait_for_pid > > from ambari_server.serverConfiguration import SSL_API, > > CLIENT_API_PORT_PROPERTY > > File > > "ambari-server/src/main/python/ambari_server/serverConfiguration.py", line > > 571, in <module> > > configDefaults = ServerConfigDefaults() > > File > > "ambari-server/src/main/python/ambari_server/serverConfiguration.py", line > > 488, in __init__ > > super(ServerConfigDefaultsLinux, self).__init__() > > File > > "ambari-server/src/main/python/ambari_server/serverConfiguration.py", line > > 343, in __init__ > > properties = get_ambari_properties() > > File > > "ambari-server/src/main/python/ambari_server/serverConfiguration.py", line > > 229, in get_ambari_properties > > conf_file = find_properties_file() > > File > > "ambari-server/src/main/python/ambari_server/serverConfiguration.py", line > > 222, in find_properties_file > > raise FatalException(1, err) > > FatalException: 'Fatal exception: File ambari.properties not found in > > search path $AMBARI_CONF_DIR: /etc/ambari-server/conf, exit code 1' > > ```
The test case test_wait_for_pid has passed in Hadoop QA and I also tried running it using python unitTests.py and it passed - Anita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154525 ----------------------------------------------------------- On Nov. 2, 2016, 6:31 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53273/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 6:31 p.m.) > > > Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18741 > https://issues.apache.org/jira/browse/AMBARI-18741 > > > Repository: ambari > > > Description > ------- > > After including client.api.port in ambari.properties, ambari-server still > tries to connect to port 8080 > > The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is > defined in ambari.properties then the value should be taken as the port > number. > > https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc > ambari-server/src/main/python/ambari_server/utils.py 348d5df > ambari-server/src/test/python/TestUtils.py 5d32125 > > Diff: https://reviews.apache.org/r/53273/diff/ > > > Testing > ------- > > Performed manual testing. > > > Thanks, > > Anita Jebaraj > >
