> On Oct. 29, 2016, 5:04 p.m., Attila Doroszlai wrote: > > Nice catch. > > > > Would be nice to use the constants defined in `serverConfiguration` for > > default port and property names. > > > > Even nicer: extract the logic for getting the port (including check for > > SSL) into a function in `serverConfiguration`. Similar logic is > > implemented in `serverUtils.get_ambari_server_api_base()`.
hi Attila....thank you..I have updated the patch based on your comments...can you please help in pushing the code? - Anita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154216 ----------------------------------------------------------- On Nov. 1, 2016, 5:39 a.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53273/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 5:39 a.m.) > > > Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18741 > https://issues.apache.org/jira/browse/AMBARI-18741 > > > Repository: ambari > > > Description > ------- > > After including client.api.port in ambari.properties, ambari-server still > tries to connect to port 8080 > > The ambari_server_ui_port is hardcoded to 8080, but if the client.api.port is > defined in ambari.properties then the value should be taken as the port > number. > > https://docs.hortonworks.com/HDPDocuments/Ambari-2.1.1.0/bk_ambari_reference_guide/content/_optional_changing_the_default_ambari_server_port.html > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/serverConfiguration.py 766f4cc > ambari-server/src/main/python/ambari_server/utils.py 5886561 > ambari-server/src/test/python/TestUtils.py 5d32125 > > Diff: https://reviews.apache.org/r/53273/diff/ > > > Testing > ------- > > Performed manual testing. > > > Thanks, > > Anita Jebaraj > >
