> On 十一月 28, 2016, 4:56 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > lines 88-90 > > <https://reviews.apache.org/r/53943/diff/1/?file=1567664#file1567664line88> > > > > 255.255.255.255 - 15 characters. But this is still not a very effective > > way to determine if the string contains 2 or more IPs. Just do the indexOf > > check instead.
Thanks Jonathan ,I have modified my code - wang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157051 ----------------------------------------------------------- On 十一月 29, 2016, 12:57 a.m., wang yaoxin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53943/ > ----------------------------------------------------------- > > (Updated 十一月 29, 2016, 12:57 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver > Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader. > > > Bugs: AMBARI-18944 > https://issues.apache.org/jira/browse/AMBARI-18944 > > > Repository: ambari > > > Description > ------- > > Mutil-agent were configured in some production environments, RemoteIp > therefore will obtain mutilple IP addresses, like > (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java > 0ac782f > > ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java > 595127e > > Diff: https://reviews.apache.org/r/53943/diff/ > > > Testing > ------- > > test done! > > > Thanks, > > wang yaoxin > >
