> On 十一月 29, 2016, 3:26 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java,
> >  lines 53-55
> > <https://reviews.apache.org/r/53943/diff/3/?file=1571806#file1571806line53>
> >
> >     This would actually do indexOf twice in cases where there are 2 or more 
> > IPs.
> >     
> >     Why not just make a method called something like 
> > normalizeIPAddress(String address) which either returns the string or 
> > returns the indexOf.
> >     
> >     This way, you only do it once.

Hi Jonathan, Thanks for  your suggestion, but this method likely requires to be 
invoked twice, unless define a variable


- wang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157255
-----------------------------------------------------------


On 十一月 29, 2016, 12:16 p.m., wang yaoxin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> -----------------------------------------------------------
> 
> (Updated 十一月 29, 2016, 12:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
>     https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> -------
> 
> RequestUtilsTest All Tests Passsed ,Process finished with exit code 0
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Reply via email to