----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157224 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java (line 82) <https://reviews.apache.org/r/53943/#comment227754> 1. typo: "mutilple" -> "multiple" 2. The text could be improved, eg.: "Checks if <code>ip</code> contains multiple IP addresses." ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java (line 83) <https://reviews.apache.org/r/53943/#comment227755> Please do not add `@param` without description. Either provide description or remove the tag. ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java (line 84) <https://reviews.apache.org/r/53943/#comment227756> Please do not add `@return` without description. Either provide description or remove the tag. ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java (line 86) <https://reviews.apache.org/r/53943/#comment227760> 1. typo: "Muti" -> "Multi" 2. Should begin with "is" by convention (although I think something like `containsMultipleRemoteAddresses` would be better) ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java (line 87) <https://reviews.apache.org/r/53943/#comment227761> unnecessary space before `;` - Attila Doroszlai On Nov. 29, 2016, 2:04 a.m., wang yaoxin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53943/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 2:04 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver > Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader. > > > Bugs: AMBARI-18944 > https://issues.apache.org/jira/browse/AMBARI-18944 > > > Repository: ambari > > > Description > ------- > > Mutil-agent were configured in some production environments, RemoteIp > therefore will obtain mutilple IP addresses, like > (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java > 0ac782f > > ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java > 595127e > > Diff: https://reviews.apache.org/r/53943/diff/ > > > Testing > ------- > > RequestUtilsTest All Tests Passsed ,Process finished with exit code 0 > > > Thanks, > > wang yaoxin > >
