----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54640/#review158806 -----------------------------------------------------------
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java (line 146) <https://reviews.apache.org/r/54640/#comment229629> No need for this function, you should use core java Files.write, or commons.io FileUtils.writeByteArrayToFile ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java (line 182) <https://reviews.apache.org/r/54640/#comment229630> Use Files, or FileUtils to write a byte array to a file, no new function is needed - Miklos Gergely On Dec. 11, 2016, 8:41 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54640/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2016, 8:41 p.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-19147 > https://issues.apache.org/jira/browse/AMBARI-19147 > > > Repository: ambari > > > Description > ------- > > Generate JKS file on startup. (if keystore is not specified or not exists) > > > Diffs > ----- > > ambari-logsearch/ambari-logsearch-portal/pom.xml 6bacd23 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java > 14f83cf > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java > 206f793 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > 2f13710 > > Diff: https://reviews.apache.org/r/54640/diff/ > > > Testing > ------- > > testing done. manually. (start ambar server, import generated logsearch > certificate to ambar keystore) > > > Thanks, > > Oliver Szabo > >
