> On Dec. 13, 2016, 2:44 p.m., Robert Levas wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java, > > line 171 > > <https://reviews.apache.org/r/54640/diff/4/?file=1582039#file1582039line171> > > > > Missing JavaDoc
i did not included any javadoc for private methods (as the methods clearly does what the method name say. if it does more, that means that method is written badly) - Oliver ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54640/#review159001 ----------------------------------------------------------- On Dec. 13, 2016, 6:56 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54640/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 6:56 p.m.) > > > Review request for Ambari, Miklos Gergely, Robert Levas, and Robert Nettleton. > > > Bugs: AMBARI-19147 > https://issues.apache.org/jira/browse/AMBARI-19147 > > > Repository: ambari > > > Description > ------- > > Generate JKS file on startup. (if keystore is not specified or not exists) > > > Diffs > ----- > > ambari-logsearch/ambari-logsearch-portal/pom.xml 6bacd23 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java > 913d25b > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java > 257ae3c > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java > 206f793 > > ambari-logsearch/ambari-logsearch-portal/src/main/resources/default.properties > c98a482 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > 2f13710 > > Diff: https://reviews.apache.org/r/54640/diff/ > > > Testing > ------- > > testing done. manually. (start ambar server, import generated logsearch > certificate to ambar keystore) > > > Thanks, > > Oliver Szabo > >
