----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54640/#review158857 -----------------------------------------------------------
Fix it, then Ship it! Overall, the patch looks fine, but I do think that there should be some more clarification on the use of the external JCE provider, so I've created an issue to track that. Can you also please add Robert Levas to this review? Thanks. ambari-logsearch/ambari-logsearch-portal/pom.xml (line 777) <https://reviews.apache.org/r/54640/#comment229678> Can you provide some more background information on why a third-party JCE provider is being introduced in this patch? Is the JCE support provided in the JDK not sufficient for the LogSearch requirements? ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java (line 244) <https://reviews.apache.org/r/54640/#comment229677> Minor typo: "does not exists" should be: "does not exist" - Robert Nettleton On Dec. 12, 2016, 11:47 a.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54640/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2016, 11:47 a.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-19147 > https://issues.apache.org/jira/browse/AMBARI-19147 > > > Repository: ambari > > > Description > ------- > > Generate JKS file on startup. (if keystore is not specified or not exists) > > > Diffs > ----- > > ambari-logsearch/ambari-logsearch-portal/pom.xml 6bacd23 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java > 14f83cf > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java > 206f793 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > 2f13710 > > Diff: https://reviews.apache.org/r/54640/diff/ > > > Testing > ------- > > testing done. manually. (start ambar server, import generated logsearch > certificate to ambar keystore) > > > Thanks, > > Oliver Szabo > >
