----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54933/#review159842 -----------------------------------------------------------
Fix it, then Ship it! Why do we need default values in both `ambari-server.py` and `kerberos_setup.py`? ambari-server/sbin/ambari-server (lines 193 - 195) <https://reviews.apache.org/r/54933/#comment230875> Indentation is off by 2 spaces. ambari-server/src/main/python/ambari_server/kerberos_setup.py (line 36) <https://reviews.apache.org/r/54933/#comment230872> `i_prop_name_default` is actually default value, isn't it? Shouldn't it be called `i_prop_val_default`? ambari-server/src/main/python/ambari_server/kerberos_setup.py (line 47) <https://reviews.apache.org/r/54933/#comment230874> When setting up kerberos, ":" is immediately followed by user input, which looks awkward. Usually the space is after the colon, not before it. (Applies to all following properties.) ambari-server/src/main/python/ambari_server/kerberos_setup.py (line 63) <https://reviews.apache.org/r/54933/#comment230873> `kerberos-setup` -> `setup-kerberos` - Attila Doroszlai On Dec. 21, 2016, 2:05 p.m., Laszlo Puskas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54933/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 2:05 p.m.) > > > Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian > Toader. > > > Bugs: AMBARI-19266 > https://issues.apache.org/jira/browse/AMBARI-19266 > > > Repository: ambari > > > Description > ------- > > For Kerberos authentication a set of properties need to be set as ambari > properties (in the ambari.properties file) > The patch adds support for these properties to be set from the command line > using the ambari-server command. > > Usage: > ambari-server setup-kerberos > > > Diffs > ----- > > ambari-server/sbin/ambari-server e0faf99 > ambari-server/src/main/python/ambari-server.py 64962d3 > ambari-server/src/main/python/ambari_server/kerberos_setup.py PRE-CREATION > ambari-server/src/main/python/ambari_server/setupActions.py 7ea0752 > > Diff: https://reviews.apache.org/r/54933/diff/ > > > Testing > ------- > > Manually. > Unit tests result (python tests only) > > Total run:1147 > > Total errors:0 > > Total failures:0 > > OK > > > Thanks, > > Laszlo Puskas > >
