> On Dec. 21, 2016, 6:41 p.m., Attila Doroszlai wrote: > > Why do we need default values in both `ambari-server.py` and > > `kerberos_setup.py`?
It's indeed a duplication, however due to time constraints i didn't check how could this be changed. (the setup-ldap functionality is implemented the same way) My assumption though is that: - primarily the arguments provided in the command line are considered, othewise the the defaults in the ambari-server.py - then the current ambari.properties are considered if they exist, otherwise the defaults in the kerberos_setup.py is considered So probably this could be simplified; it needs some time to figure this out and find an elegant way to overcome this. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54933/#review159842 ----------------------------------------------------------- On Dec. 21, 2016, 1:05 p.m., Laszlo Puskas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54933/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 1:05 p.m.) > > > Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian > Toader. > > > Bugs: AMBARI-19266 > https://issues.apache.org/jira/browse/AMBARI-19266 > > > Repository: ambari > > > Description > ------- > > For Kerberos authentication a set of properties need to be set as ambari > properties (in the ambari.properties file) > The patch adds support for these properties to be set from the command line > using the ambari-server command. > > Usage: > ambari-server setup-kerberos > > > Diffs > ----- > > ambari-server/sbin/ambari-server e0faf99 > ambari-server/src/main/python/ambari-server.py 64962d3 > ambari-server/src/main/python/ambari_server/kerberos_setup.py PRE-CREATION > ambari-server/src/main/python/ambari_server/setupActions.py 7ea0752 > > Diff: https://reviews.apache.org/r/54933/diff/ > > > Testing > ------- > > Manually. > Unit tests result (python tests only) > > Total run:1147 > > Total errors:0 > > Total failures:0 > > OK > > > Thanks, > > Laszlo Puskas > >
