> On Jan. 5, 2017, 11:10 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql, line 185 > > <https://reviews.apache.org/r/55207/diff/1/?file=1597268#file1597268line185> > > > > Typo; extra NOT. Should be: > > > > repo_state VARCHAR2(255) DEFAULT 'INIT' NOT NULL,
Good catch. Will fix. > On Jan. 5, 2017, 11:10 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java, > > lines 643-645 > > <https://reviews.apache.org/r/55207/diff/1/?file=1597264#file1597264line643> > > > > So the event which invokes this is done on a synchronous bus. I think > > it's synchronous b/c the heartbeat processor uses the results, so it has to > > be done on the thread handling the heartbeat. > > > > This method does a lot with the database, which will slow down the > > thread. On a large cluster, could this be a problem? If the heartbeat > > processor doesn't use the result of this method's calculations, then > > perhaps we can create a new async bus for this kind of stuff. It would > > still listen to the same event being fired from the heartbeat processor. > > > > Doesn't even need to change in this review - just thought I'd flag it > > for discussion. There is a lot of DB work, but the amount done with this change isn't much more than what was there (one extra query). I'll open a new JIRA. > On Jan. 5, 2017, 11:10 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java, > > lines 120-121 > > <https://reviews.apache.org/r/55207/diff/1/?file=1597264#file1597264line120> > > > > Just as a point (don't need to change it now), but unless the > > constructor (or a method it calls) needs these, you can just @Inject them > > and not worry about having them in the ctor. Ah, yes, you're right - brain freeze from having to write jaaaaahhhhhvaahhhhhh :) Will fix, as I found a bunch of checkstyle warnings anyway. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55207/#review160598 ----------------------------------------------------------- On Jan. 5, 2017, 8:12 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55207/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 8:12 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-19381 > https://issues.apache.org/jira/browse/AMBARI-19381 > > > Repository: ambari > > > Description > ------- > > The repository version per component and state of the repository should be > updated on heartbeat just as cluster is. > > Long term, the cluster_version will no longer be used; that is a separate > effort. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java > 9dbda20 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 65cfcaa > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > f5a5b0c > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java > cc7b503 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java > 987e44f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > 9d35e2a > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java > 9b93517 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java > 5085d18 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java > e93ab9a > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 236091b > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > d6bbbac > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 > ambari-server/src/main/resources/properties.json b7e0988 > > ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java > 045d017 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java > 3529bef > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 15e81c5 > > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java > 0f615ee > > Diff: https://reviews.apache.org/r/55207/diff/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
