----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55207/#review160602 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java (lines 120 - 121) <https://reviews.apache.org/r/55207/#comment231736> Either way - I'm fine leaving it. It's actually a nice pattern to have for testing. Lets you pass in mocks for these DAOs if you need to. Sometimes for tests it's easier to overload the ctor like this. Anyway, it was just something to mention. - Jonathan Hurley On Jan. 5, 2017, 8:12 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55207/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 8:12 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-19381 > https://issues.apache.org/jira/browse/AMBARI-19381 > > > Repository: ambari > > > Description > ------- > > The repository version per component and state of the repository should be > updated on heartbeat just as cluster is. > > Long term, the cluster_version will no longer be used; that is a separate > effort. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java > 9dbda20 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 65cfcaa > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > f5a5b0c > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java > cc7b503 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java > 987e44f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > 9d35e2a > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java > 9b93517 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java > 5085d18 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java > e93ab9a > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 236091b > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > d6bbbac > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 > ambari-server/src/main/resources/properties.json b7e0988 > > ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java > 045d017 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java > 3529bef > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 15e81c5 > > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java > 0f615ee > > Diff: https://reviews.apache.org/r/55207/diff/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
