> On Jan. 5, 2017, 1:59 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java, > > line 73 > > <https://reviews.apache.org/r/55207/diff/2/?file=1597647#file1597647line73> > > > > What should the behavior be if the record has a version of NONE? No > > comparison will happen.
By the time this code is invoked, we already know that serviceName and componentName are advertiseVersion=true, so any component that has not yet given us their version makes the logic the same (if we don't know the version, we're still OUT_OF_SYNC) - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55207/#review160613 ----------------------------------------------------------- On Jan. 5, 2017, 1:37 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55207/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 1:37 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-19381 > https://issues.apache.org/jira/browse/AMBARI-19381 > > > Repository: ambari > > > Description > ------- > > The repository version per component and state of the repository should be > updated on heartbeat just as cluster is. > > Long term, the cluster_version will no longer be used; that is a separate > effort. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > 0046ec6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java > 9dbda20 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 65cfcaa > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 7c90cab > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > f5a5b0c > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java > cc7b503 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java > 987e44f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > 9d35e2a > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java > 210de62 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java > 9b93517 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java > 5085d18 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java > e93ab9a > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 236091b > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 7d35d2e > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > d6bbbac > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 > ambari-server/src/main/resources/properties.json b7e0988 > > ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java > 7758924 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java > 3529bef > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java > fb508ea > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > ead0a2d > > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java > 0f615ee > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java > 36afa03 > > Diff: https://reviews.apache.org/r/55207/diff/ > > > Testing > ------- > > Manual. Automated: > > > Results : > > Tests run: 4837, Failures: 0, Errors: 0, Skipped: 37 > > > Thanks, > > Nate Cole > >
