-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56022/
-----------------------------------------------------------

(Updated Jan. 27, 2017, 7:11 p.m.)


Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.


Changes
-------

fixed tests


Bugs: AMBARI-19683
    https://issues.apache.org/jira/browse/AMBARI-19683


Repository: ambari


Description
-------

Exported YARN configuration was different than the stored configuration. I 
replaced the Python logic that assembled yarn security opt with jinja template 
logic.


Diffs (updated)
-----

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 c56e72f 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml
 190684c 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 92e2e29 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
774f3c6 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
da93096 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1 

Diff: https://reviews.apache.org/r/56022/diff/


Testing (updated)
-------

Tested manually:
 - created a cluster with YARN
 - enabled kerberos
 - exported configuration
 - checked that yarn security opts are presented in the exported config
 - disablde kerberos
 - checked that yarn security opts are not presented in the exported config

existing unittests ran successfully
one irrelevant failure:

java.lang.AssertionError
org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC


Thanks,

Attila Magyar

Reply via email to