----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56022/#review163694 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml (line 21) <https://reviews.apache.org/r/56022/#comment235169> Does this file differ from the one used for HDP 3.0? If so, they need to be identical for now, until we figure out what will change in HDP 3.0. - Alejandro Fernandez On Jan. 31, 2017, 1:43 p.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56022/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2017, 1:43 p.m.) > > > Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader. > > > Bugs: AMBARI-19683 > https://issues.apache.org/jira/browse/AMBARI-19683 > > > Repository: ambari > > > Description > ------- > > Exported YARN configuration was different than the stored configuration. I > replaced the Python logic that assembled yarn security opt with jinja > template logic. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > aed8abc > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml > d8531b1 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py > 4d47925 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/metainfo.xml > ad457b2 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > 62a4d46 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py > 774f3c6 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py > 5ebfb45 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1 > > Diff: https://reviews.apache.org/r/56022/diff/ > > > Testing > ------- > > Tested manually: > - created a cluster with YARN > - enabled kerberos > - exported configuration > - checked that yarn security opts are presented in the exported config > - disablde kerberos > - checked that yarn security opts are not presented in the exported config > > existing unittests ran successfully > one irrelevant failure: > > java.lang.AssertionError > org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC > > > Thanks, > > Attila Magyar > >
