> On Jan. 27, 2017, 7 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml, > > line 157 > > <https://reviews.apache.org/r/56022/diff/1/?file=1617907#file1617907line157> > > > > In that case, this should belong in yarn-env for HDP 2.6. > > Earlier versions will not have the rm_security_ops variable in params.py > > Sebastian Toader wrote: > Does config export clever enough currently to pick up yarn-env template > from HDP 2.6 in case the cluster is using HDP 2.6?
It is wrapped into a conditional that checks whether rm_security_opts is defined (and it is only defined when stack is 2.6). HDP 2.6 doesn't have yarn-env.xml. I should have duplicated the whole file from 2.3 - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56022/#review163309 ----------------------------------------------------------- On Jan. 27, 2017, 7:11 p.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56022/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 7:11 p.m.) > > > Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader. > > > Bugs: AMBARI-19683 > https://issues.apache.org/jira/browse/AMBARI-19683 > > > Repository: ambari > > > Description > ------- > > Exported YARN configuration was different than the stored configuration. I > replaced the Python logic that assembled yarn security opt with jinja > template logic. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > c56e72f > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml > 190684c > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > 92e2e29 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py > 774f3c6 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 0eb5561 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py > da93096 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py d4341e1 > > Diff: https://reviews.apache.org/r/56022/diff/ > > > Testing > ------- > > Tested manually: > - created a cluster with YARN > - enabled kerberos > - exported configuration > - checked that yarn security opts are presented in the exported config > - disablde kerberos > - checked that yarn security opts are not presented in the exported config > > existing unittests ran successfully > one irrelevant failure: > > java.lang.AssertionError > org.apache.ambari.server.serveraction.kerberos.UpdateKerberosConfigsServerActionTest.testUpdateConfigForceSecurityEnabled(UpdateKerberosC > > > Thanks, > > Attila Magyar > >
