----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review167838 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java Lines 4324 (patched) <https://reviews.apache.org/r/57168/#comment239800> Why did you need to restore the keys ? stringPropertyNames already returns a Set object that you may use directly. ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java Lines 4327 (patched) <https://reviews.apache.org/r/57168/#comment239799> close instream in finally{} ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java Lines 4329 (patched) <https://reviews.apache.org/r/57168/#comment239803> How did Ambari server react to an i/o exception on the blacklist file? Please make sure Ambari server start restarts successfully even when the blacklist file causes an i/o exception as I don't think it's a sev1 err like some others in this class, i.e. can't read db pwd, can't read ssl cert pwd. ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java Lines 168 (patched) <https://reviews.apache.org/r/57168/#comment239801> The second "tab" seemed to be a real tab than 2 white spaces. please make sure all tabs are replaced by spaces. You can set that in Eclipse as a general setting. - Di Li On March 2, 2017, 1:05 a.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57168/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 1:05 a.m.) > > > Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, > and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20243 > https://issues.apache.org/jira/browse/AMBARI-20243 > > > Repository: ambari > > > Description > ------- > > Currently all the details from the ambari.properties file is being returned > by the API call. > > Some of those information may not be utilized and hence an option can be > provided to filter the properties > > A ambari-blacklist.properties file can be created, the properties that are > entered in the file, will be removed from the api call that returns the > ambari.properties. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > eaecf35 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > dadcf09 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 51114f8 > > > Diff: https://reviews.apache.org/r/57168/diff/3/ > > > Testing > ------- > > Added 1 test case > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
