----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review168320 -----------------------------------------------------------
Since you're adding a new property, can you run the markdown generator: mvn exec:java or mvn exec:java@configuration-markdown (on maven 3.3.1 and later) ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java Lines 4314-4336 (patched) <https://reviews.apache.org/r/57168/#comment240537> This reads from the stream on every invocation. Since it's called a REST endpoint, that means the response is based on disk I/O ... can we just load these once on startup like other configuration properties? - Jonathan Hurley On March 8, 2017, noon, Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57168/ > ----------------------------------------------------------- > > (Updated March 8, 2017, noon) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr > Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20243 > https://issues.apache.org/jira/browse/AMBARI-20243 > > > Repository: ambari > > > Description > ------- > > Currently all the details from the ambari.properties file is being returned > by the API call. > > Some of those information may not be utilized and hence an option can be > provided to filter the properties > > A ambari-blacklist.properties file can be created, the properties that are > entered in the file, will be removed from the api call that returns the > ambari.properties. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 0991814 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > dadcf09 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 51114f8 > > > Diff: https://reviews.apache.org/r/57168/diff/5/ > > > Testing > ------- > > Added 1 test case > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
