----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review168045 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java Lines 4328 (patched) <https://reviews.apache.org/r/57168/#comment240074> This should be an error. Use String.format instead of "+". ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java Lines 165 (patched) <https://reviews.apache.org/r/57168/#comment240090> The for loop should not run anyway when propertiesToHideInResponse is empty. - Di Li On March 3, 2017, 8:47 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57168/ > ----------------------------------------------------------- > > (Updated March 3, 2017, 8:47 p.m.) > > > Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, > and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20243 > https://issues.apache.org/jira/browse/AMBARI-20243 > > > Repository: ambari > > > Description > ------- > > Currently all the details from the ambari.properties file is being returned > by the API call. > > Some of those information may not be utilized and hence an option can be > provided to filter the properties > > A ambari-blacklist.properties file can be created, the properties that are > entered in the file, will be removed from the api call that returns the > ambari.properties. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > eaecf35 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > dadcf09 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 51114f8 > > > Diff: https://reviews.apache.org/r/57168/diff/4/ > > > Testing > ------- > > Added 1 test case > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
