> On March 10, 2017, 3:40 p.m., Jonathan Hurley wrote:
> > Ship It!

Thank you Jonathan for reviewing, I had to update the patch since there was an 
unnecessarily check lingering around in the patch, 
+        if(propertiesToHideInResponse != null) { 
this wont be required now since its assigned to an empty set on the invocation 
of the method. Can you please check this out and help me in pushing the changes 
to trunk


- Anita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review168626
-----------------------------------------------------------


On March 10, 2017, 3:34 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 3:34 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr 
> Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
>     https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/configuration/index.md af962e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  df334c5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  8111a39 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/8/
> 
> 
> Testing
> -------
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Reply via email to