----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review168610 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java Lines 4356 (patched) <https://reviews.apache.org/r/57168/#comment240867> Can you initialize this on the first invocation of this method? That way, if the black list file isn't defined, it doesn't have to go through the check over and over. - Jonathan Hurley On March 8, 2017, 6:30 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57168/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 6:30 p.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jonathan Hurley, Oleksandr > Diachenko, Sangeeta Ravindran, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20243 > https://issues.apache.org/jira/browse/AMBARI-20243 > > > Repository: ambari > > > Description > ------- > > Currently all the details from the ambari.properties file is being returned > by the API call. > > Some of those information may not be utilized and hence an option can be > provided to filter the properties > > A ambari-blacklist.properties file can be created, the properties that are > entered in the file, will be removed from the api call that returns the > ambari.properties. > > > Diffs > ----- > > ambari-server/docs/configuration/index.md af962e1 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > df334c5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > dadcf09 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 51114f8 > > > Diff: https://reviews.apache.org/r/57168/diff/6/ > > > Testing > ------- > > Added 1 test case > Ran mvn test > > > Thanks, > > Anita Jebaraj > >
