----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57563/#review170888 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java Lines 931 (patched) <https://reviews.apache.org/r/57563/#comment243750> Does this mean bp export will always set it to false ? ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java Line 21 (original), 21 (patched) <https://reviews.apache.org/r/57563/#comment243749> why change the junit classes imported ? - Di Li On April 3, 2017, 4:42 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57563/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 4:42 p.m.) > > > Review request for Ambari, Di Li and Robert Levas. > > > Bugs: AMBARI-20386 > https://issues.apache.org/jira/browse/AMBARI-20386 > > > Repository: ambari > > > Description > ------- > > Blueprint validation does not prompt if kdc_hosts is not specified in the > blueprint. After service installation, deployment fails during Create > Principal stage. As /etc/krb5.conf is overwritten with blank values. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > db1aa074d4 > > ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java > 13db5f8b56 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > dba40437ae > > > Diff: https://reviews.apache.org/r/57563/diff/2/ > > > Testing > ------- > > Manual testing done, if no kdc_hosts is mentioned then validation exception > will be thrown during blueprint registration. > > > Thanks, > > Amruta Borkar > >
