> On April 3, 2017, 6:11 p.m., Robert Nettleton wrote: > > Thanks for providing this patch, but I don't really think that this is the > > correct way to solve this problem. > > > > The Blueprint export shouldn't really modify any configuration in the > > cluster. The export process may filter out some information (passwords, > > hostnames for un-managed services, etc), but no configuration property > > changes should be made. > > > > In the future, it would be great if Blueprints provided a validation step > > for the configuration in a Blueprint/Cluster Creation template, as that > > would resolve the initial issue described. Unfortunately, such a framework > > does not yet exist in Blueprints, and would require refactoring of the > > stack definitions, such that the Blueprint processor could validate > > configuration properties in a generic fashion. > > Amruta Borkar wrote: > Hello Robert, > Thanks for the feedback. Would it be a good idea to handle the validation > mentioned by Robert Levas in BlueprintValidatorImpl ?
Hi Amruta, At some point, it would be good to add validation support for configuration values, and that would likely go into the BlueprintValidation/BlueprintValidatorImpl. The problem here is that we probably should not add any hard-coded rules in the validator for specific configuration, since we already have too much hard-coded rules in the Blueprint procesor as it currently stands. I think that a future release should include support in the stacks for declaring rules about configuration properties, which the Blueprint validator could then enforce. Thanks. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57563/#review170908 ----------------------------------------------------------- On April 3, 2017, 4:42 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57563/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 4:42 p.m.) > > > Review request for Ambari, Di Li, Robert Levas, and Robert Nettleton. > > > Bugs: AMBARI-20386 > https://issues.apache.org/jira/browse/AMBARI-20386 > > > Repository: ambari > > > Description > ------- > > Blueprint validation does not prompt if kdc_hosts is not specified in the > blueprint. After service installation, deployment fails during Create > Principal stage. As /etc/krb5.conf is overwritten with blank values. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > db1aa074d4 > > ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java > 13db5f8b56 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > dba40437ae > > > Diff: https://reviews.apache.org/r/57563/diff/2/ > > > Testing > ------- > > Manual testing done, if no kdc_hosts is mentioned then validation exception > will be thrown during blueprint registration. > > > Thanks, > > Amruta Borkar > >
