----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57563/#review170908 -----------------------------------------------------------
Thanks for providing this patch, but I don't really think that this is the correct way to solve this problem. The Blueprint export shouldn't really modify any configuration in the cluster. The export process may filter out some information (passwords, hostnames for un-managed services, etc), but no configuration property changes should be made. In the future, it would be great if Blueprints provided a validation step for the configuration in a Blueprint/Cluster Creation template, as that would resolve the initial issue described. Unfortunately, such a framework does not yet exist in Blueprints, and would require refactoring of the stack definitions, such that the Blueprint processor could validate configuration properties in a generic fashion. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java Lines 935 (patched) <https://reviews.apache.org/r/57563/#comment243763> I agree with the previous issues raised about this method. The property should not be set to false merely to export a Blueprint. While it is true that the kdc_host is stripped out of an exported Blueprint, the other Kerberos configuration should remain intact, so that the exported Blueprint could be used more portably. - Robert Nettleton On April 3, 2017, 4:42 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57563/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 4:42 p.m.) > > > Review request for Ambari, Di Li and Robert Levas. > > > Bugs: AMBARI-20386 > https://issues.apache.org/jira/browse/AMBARI-20386 > > > Repository: ambari > > > Description > ------- > > Blueprint validation does not prompt if kdc_hosts is not specified in the > blueprint. After service installation, deployment fails during Create > Principal stage. As /etc/krb5.conf is overwritten with blank values. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > db1aa074d4 > > ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java > 13db5f8b56 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > dba40437ae > > > Diff: https://reviews.apache.org/r/57563/diff/2/ > > > Testing > ------- > > Manual testing done, if no kdc_hosts is mentioned then validation exception > will be thrown during blueprint registration. > > > Thanks, > > Amruta Borkar > >
