----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179074 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java Lines 336 (patched) <https://reviews.apache.org/r/60481/#comment253513> Why put a specific version in the message here? ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java Lines 34-35 (patched) <https://reviews.apache.org/r/60481/#comment253487> "Hive Metastore"? ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java Lines 44 (patched) <https://reviews.apache.org/r/60481/#comment253502> Comment belongs to previous line, doesn't it? ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java Lines 82 (patched) <https://reviews.apache.org/r/60481/#comment253492> Seems to have 2 arguments for single `%s`. What does the message turn out in this case? Isn't it something like "... requires at least JDK Java ..."? ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java Lines 93 (patched) <https://reviews.apache.org/r/60481/#comment253506> `javaVersionS` may be null, which shouldn't be displayed in the formatted message ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java Lines 95 (patched) <https://reviews.apache.org/r/60481/#comment253489> unnecessary - Attila Doroszlai On June 27, 2017, 11:02 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60481/ > ----------------------------------------------------------- > > (Updated June 27, 2017, 11:02 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe. > > > Bugs: AMBARI-21359 > https://issues.apache.org/jira/browse/AMBARI-21359 > > > Repository: ambari > > > Description > ------- > > This is for the JavaVersionCheck check defined in the cross stack upgrade > pack EU xml file. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 71c5857 > > ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60481/diff/1/ > > > Testing > ------- > > to be tested later on with the integrated tests. > > > Thanks, > > Di Li > >
