----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179106 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java Lines 42 (patched) <https://reviews.apache.org/r/60481/#comment253590> Is this the minimum version for Ambari? Configuration defines this differently: https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java#L180-L183 Should we be using that instead? ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java Lines 57 (patched) <https://reviews.apache.org/r/60481/#comment253586> Probably not necessary... ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java Lines 64 (patched) <https://reviews.apache.org/r/60481/#comment253588> Is there an extra S on the end of this? - Jonathan Hurley On June 28, 2017, 9:34 a.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60481/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 9:34 a.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe. > > > Bugs: AMBARI-21359 > https://issues.apache.org/jira/browse/AMBARI-21359 > > > Repository: ambari > > > Description > ------- > > This is for the JavaVersionCheck check defined in the cross stack upgrade > pack EU xml file. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 71c5857 > > ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60481/diff/2/ > > > Testing > ------- > > to be tested later on with the integrated tests. > > > Thanks, > > Di Li > >
