> On June 28, 2017, 2:45 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java > > Lines 57 (patched) > > <https://reviews.apache.org/r/60481/diff/2/?file=1766161#file1766161line57> > > > > Probably not necessary...
you are right, I removed it. > On June 28, 2017, 2:45 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java > > Lines 64 (patched) > > <https://reviews.apache.org/r/60481/diff/2/?file=1766161#file1766161line64> > > > > Is there an extra S on the end of this? yeah, removed it. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179106 ----------------------------------------------------------- On June 28, 2017, 3:16 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60481/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 3:16 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe. > > > Bugs: AMBARI-21359 > https://issues.apache.org/jira/browse/AMBARI-21359 > > > Repository: ambari > > > Description > ------- > > This is for the JavaVersionCheck check defined in the cross stack upgrade > pack EU xml file. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 71c5857 > > ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60481/diff/3/ > > > Testing > ------- > > to be tested later on with the integrated tests. > > > Thanks, > > Di Li > >
