> On July 6, 2017, 9:44 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > > Lines 446 (patched) > > <https://reviews.apache.org/r/60691/diff/1/?file=1770775#file1770775line446> > > > > I believe default() will already convert the string "true" or "false" > > into the boolean True or False. > > > > If not, then the 3rd line here has a bug since it should compare it to > > "true"
This is to make sure the script checks value true/false (case insentive). Otherwise the check becomes falsy vs truthy as people can set value to something like "yes/no", or even just a non-empty string. Yes, the logic has a bug, I missed the quotes. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60691/#review179830 ----------------------------------------------------------- On July 6, 2017, 9:08 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60691/ > ----------------------------------------------------------- > > (Updated July 6, 2017, 9:08 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, > Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe. > > > Bugs: AMBARI-21420 > https://issues.apache.org/jira/browse/AMBARI-21420 > > > Repository: ambari > > > Description > ------- > > HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. > HBase master appeared as if it had started according to the Ambari action log > but later crashed with error: > 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] > master.HMaster: Failed to become active masterjava.io.IOException: The > procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure > must be accessible and have an empty constructorat > org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at > org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at > org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at > > org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at > > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at > > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at > > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at > > org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at > org.apach e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196) > Attach one or more files to this issue > Attachments > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py > a1003dc > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 43c6036 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > 419e5dd > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > c4737c9 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml > 419e5dd > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > c4737c9 > > > Diff: https://reviews.apache.org/r/60691/diff/1/ > > > Testing > ------- > > will be tested in the integration tests. > > > Thanks, > > Di Li > >
