----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60691/#review179890 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py Lines 446 (patched) <https://reviews.apache.org/r/60691/#comment254794> This still has a bug, I believe default("someconfig") will actually return the boolean, but if not defined you're setting the default to the string "false", so the type will be different. Once you do convert to str() in the next line, the case will be different, and finally, you cannot compare the string to the boolean true in the following line. - Alejandro Fernandez On July 7, 2017, 1:15 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60691/ > ----------------------------------------------------------- > > (Updated July 7, 2017, 1:15 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, > Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe. > > > Bugs: AMBARI-21420 > https://issues.apache.org/jira/browse/AMBARI-21420 > > > Repository: ambari > > > Description > ------- > > HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. > HBase master appeared as if it had started according to the Ambari action log > but later crashed with error: > 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] > master.HMaster: Failed to become active masterjava.io.IOException: The > procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure > must be accessible and have an empty constructorat > org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at > org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at > org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at > > org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at > > org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at > > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at > > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at > > org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at > org.apach e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196) > Attach one or more files to this issue > Attachments > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py > a1003dc > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 43c6036 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > 6597055 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > af87794 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml > 6597055 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > af87794 > > > Diff: https://reviews.apache.org/r/60691/diff/2/ > > > Testing > ------- > > will be tested in the integration tests. > > > Thanks, > > Di Li > >
