-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60691/#review179888
-----------------------------------------------------------


Fix it, then Ship it!




I don't know enough about HBase internals - is removing the write-ahead log 
safe - especially during a complex upgrade? Isn't it like a last line of 
defense in case something goes very wrong?


ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
Lines 41-43 (patched)
<https://reviews.apache.org/r/60691/#comment254788>

    Do we need to worry about running this with kinit if Kerberized? If not, 
you can drop this issue.



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
Lines 442 (patched)
<https://reviews.apache.org/r/60691/#comment254785>

    What's being formatted here?


- Jonathan Hurley


On July 7, 2017, 9:15 a.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60691/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 9:15 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21420
>     https://issues.apache.org/jira/browse/AMBARI-21420
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HBase in IOP 4.2.5 is of higher version than the one shipped in HDP 2.6. 
> HBase master appeared as if it had started according to the Ambari action log 
> but later crashed with error:
> 2017-07-05 09:28:08,952 FATAL [hats1:16000.activeMasterManager] 
> master.HMaster: Failed to become active masterjava.io.IOException: The 
> procedure class org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure 
> must be accessible and have an empty constructorat 
> org.apache.hadoop.hbase.procedure2.Procedure.newInstance(Procedure.java:663)at
>  org.apache.hadoop.hbase.procedure2.Procedure.convert(Procedure.java:789)at 
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.read(ProcedureWALFormatReader.java:111)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:81)at
>  
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:374)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:297)at
>  
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.start(ProcedureExecutor.java:464)at
>  
> org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1297)at
>  org.apach
 e.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1196)
> Attach one or more files to this issue
> Attachments
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a1003dc 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  43c6036 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml
>  6597055 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  af87794 
> 
> 
> Diff: https://reviews.apache.org/r/60691/diff/2/
> 
> 
> Testing
> -------
> 
> will be tested in the integration tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Reply via email to