> On Aug. 24, 2017, 1:30 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > > Lines 1428-1431 (original), 1444-1452 (patched) > > <https://reviews.apache.org/r/61833/diff/3/?file=1802355#file1802355line1444> > > > > Is this really a problem? It's something that we see all the time, even > > when just starting up. Does the fact that the config type is missing from > > allConfigs signify a problem? If not, we can just not log it. > > > > If we want to keep looking it, then why not just find all missing types > > and print 1 log message with them separated by StringUtils.join(), and then > > suppresss that one message.
Fair enough, I am thinking of moving this as a Warnign in the DB consistency checker where user sees it once and can actually autofix it if needed. Opinion? - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61833/#review183736 ----------------------------------------------------------- On Aug. 23, 2017, 8:05 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61833/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 8:05 p.m.) > > > Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Sumit > Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-21784 > https://issues.apache.org/jira/browse/AMBARI-21784 > > > Repository: ambari > > > Description > ------- > > Ambari server log is constantly populated with 'Config inconsistency exists: > unknown configType=solr-site' even after Solr deletion due to existence of > config group. > > {code} > 22 Aug 2017 19:00:20,094 ERROR [ambari-hearbeat-monitor] HostImpl:1085 - > Config inconsistency exists: unknown configType=solr-site > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java > 200cf27 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 3fb45ab > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupFactory.java > 906d948 > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java > 9058a63 > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java > 7282485 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 5214f04 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java > eec379e > > ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java > c70dcc6 > > ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java > 21ce2c2 > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java > 1ad8cef > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > e8e7206 > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > fc1f334 > > > Diff: https://reviews.apache.org/r/61833/diff/3/ > > > Testing > ------- > > Manually verfied with a 2.5.2 cluster. > Unit test added. > All modified unit test pass. > > > Thanks, > > Sid Wagle > >
