-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61833/
-----------------------------------------------------------
(Updated Aug. 24, 2017, 6:46 p.m.)
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Sumit
Mohanty, and Sebastian Toader.
Changes
-------
Addressed concerns from Jonathan regarding unnecessary logging in the main code
path and moved the check aswell as fix to db checker.
Bugs: AMBARI-21784
https://issues.apache.org/jira/browse/AMBARI-21784
Repository: ambari
Description
-------
Ambari server log is constantly populated with 'Config inconsistency exists:
unknown configType=solr-site' even after Solr deletion due to existence of
config group.
{code}
22 Aug 2017 19:00:20,094 ERROR [ambari-hearbeat-monitor] HostImpl:1085 - Config
inconsistency exists: unknown configType=solr-site
{code}
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
40049c0
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
200cf27
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
3fb45ab
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupFactory.java
906d948
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
9058a63
ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java
7282485
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
9e85fa2
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
5214f04
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
eec379e
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java
c70dcc6
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
21ce2c2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java
1ad8cef
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
e8e7206
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
fc1f334
Diff: https://reviews.apache.org/r/61833/diff/4/
Changes: https://reviews.apache.org/r/61833/diff/3-4/
Testing
-------
Manually verfied with a 2.5.2 cluster.
Unit test added.
All modified unit test pass.
Thanks,
Sid Wagle
