----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review81745 -----------------------------------------------------------
LGTM, only comment is a ship blocker though. src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java <https://reviews.apache.org/r/33243/#comment132177> Remove `credentials.get()`, it will throw a NullPointerException in this branch. - Bill Farner On April 27, 2015, 10:44 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33243/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 10:44 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-1228 > https://issues.apache.org/jira/browse/AURORA-1228 > > > Repository: aurora > > > Description > ------- > > The scheduler now explicitly acknowledges updates. I left the structure as > is, per Bill's suggestion. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java > db7aa74c2dfca3d520d978d7837d1f2639e6c05c > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > f40746b5712f21e551c06eeb1aa379ebdcdbc693 > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java > 4ef23ea6ebd2c9587a8356507fcb49a36b9de219 > > Diff: https://reviews.apache.org/r/33243/diff/ > > > Testing > ------- > > Ran the unit tests and the end-to-end test. > > > Thanks, > > Ben Mahler > >
