----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91790 -----------------------------------------------------------
Ship it! LGTM, i caused one nit - remove that and i'll commit :-) src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (lines 168 - 169) <https://reviews.apache.org/r/36436/#comment145438> Sorry, i made that suggestion before i added the comment to break out constants and multiply. Feel free to nuke this :-/ - Bill Farner On July 15, 2015, 6:08 p.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36436/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 6:08 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1096 > https://issues.apache.org/jira/browse/AURORA-1096 > > > Repository: aurora > > > Description > ------- > > Prevent job updates from allowing unbounded instance events > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > dc0cd2d71d11b8157154f7b63a14f0282dee09f1 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > d28baba7618ebb194a61455971786aef46abd8eb > > Diff: https://reviews.apache.org/r/36436/diff/ > > > Testing > ------- > > `./gradlew build -Pq` > > > Thanks, > > Joe Smith > >
